RE: [net-next 05/13] igb: Add support for debugfs

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of Or Gerlitz
Sent: Wednesday, March 12, 2014 8:58 AM
To: Kirsher, Jeffrey T; David Miller; Andy Gospodarek
Cc: Wyborny, Carolyn; netdev@vger.kernel.org; sassmann@redhat.com; Josh
Hay; Amir Vadai; Yevgeny Petrilin
Subject: Re: [net-next 05/13] igb: Add support for debugfs

On Wed, Mar 12, 2014 at 7:53 AM, Jeff Kirsher [off-list ref]
wrote:

quoted

This patch adds the necessary defines, variables, and stats updating
procedures to use the commands implemented in debugfs.

Guys,

Do we have a clear criteria when it makes sense to have debugfs for network
driver and when it doesn't, for example we got this cold shower
http://marc.info/?l=linux-netdev&m=135959539719935&w=2 when attempting
to do so and I am not fully clear (or want to sharpen the sow) how to review a
concrete design/need for debugs to fall into yes, it makes sense, or no, it
doesn't b/c there are existing mechanisms that can be used or extended for that
matter.

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a
message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

Josh and I tried very hard to not reimplement anything already available in some other tool or mechanism and used the examples we already have for this in our other drivers.  That being said, we'll abide and follow any clear criteria provided.

Thanks,

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation