Thread (14 messages) flat view 14 messages, 7 authors, 2014-02-13

Re: [PATCH] net: correct error path in rtnl_newlink()

From: David Miller <davem@davemloft.net>
Date: 2014-02-13 22:13:31

From: Cong Wang <redacted>
Date: Tue, 11 Feb 2014 15:51:30 -0800
From: Cong Wang <redacted>

I saw the following BUG when ->newlink() fails in rtnl_newlink():

[   40.240058] kernel BUG at net/core/dev.c:6438!

this is due to free_netdev() is not supposed to be called before
netdev is completely unregistered, therefore it is not correct
to call free_netdev() here, at least for ops->newlink!=NULL case,
many drivers call it in ->destructor so that rtnl_unlock() will
take care of it, we probably don't need to do anything here.

Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <redacted>
Signed-off-by: Cong Wang <redacted>
Signed-off-by: Cong Wang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help