[PATCH] net: clear iflink when moving to a new netns · Cong Wang <hidden> · 2014-02-11
[PATCH] macvlan: unregister net device when netdev_upper_dev_link() fails · Cong Wang <hidden> · 2014-02-11
Re: [PATCH] macvlan: unregister net device when netdev_upper_dev_link() fails · David Miller <davem@davemloft.net> · 2014-02-13
[PATCH] net: correct error path in rtnl_newlink() · Cong Wang <hidden> · 2014-02-11
Re: [PATCH] net: correct error path in rtnl_newlink() · David Miller <davem@davemloft.net> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Nicolas Dichtel <hidden> · 2014-02-12
Re: [PATCH] net: clear iflink when moving to a new netns · Cong Wang <hidden> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Eric W. Biederman <hidden> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Cong Wang <hidden> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Stephen Hemminger <stephen@networkplumber.org> · 2014-02-12
Re: [PATCH] net: clear iflink when moving to a new netns · Cong Wang <hidden> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Eric W. Biederman <hidden> · 2014-02-13
Re: [PATCH] net: clear iflink when moving to a new netns · Ben Hutchings <hidden> · 2014-02-12
Re: [PATCH] net: clear iflink when moving to a new netns · Cong Wang <hidden> · 2014-02-13

Re: [PATCH] net: clear iflink when moving to a new netns

From: Eric W. Biederman <hidden>
Date: 2014-02-13 02:01:55

Cong Wang [off-list ref] writes:

On Wed, Feb 12, 2014 at 8:33 AM, Stephen Hemminger
[off-list ref] wrote:

quoted

This also breaks propogation of state changes from lower device
to upper device. Things like carrier and up/down.

macvlan_device_event() handles this pretty well by using a pointer to
net_device.
I don't see it is a problem from the code.

A quick grep shows two uses of iflink in net/core/link_watch.c that are
likely broken by your proposed change.

Eric