Hello.

On 01/20/2014 10:16 PM, David Miller wrote:

quoted

quoted

quoted

quoted

quoted

- added '__packed' to 'struct rcar_can_mbox_regs' and 'struct rcar_can_regs';
- removed unneeded type cast in the probe() method.

quoted

quoted

quoted

quoted

quoted

+/* Mailbox registers structure */
+struct rcar_can_mbox_regs {
+       u32 id;         /* IDE and RTR bits, SID and EID */
+       u8 stub;        /* Not used */
+       u8 dlc;         /* Data Length Code - bits [0..3] */
+       u8 data[8];     /* Data Bytes */
+       u8 tsh;         /* Time Stamp Higher Byte */
+       u8 tsl;         /* Time Stamp Lower Byte */
+} __packed;

quoted

quoted

quoted

quoted

Sorry, I missed the earlier discussion, but why the _packed?
One u32 and 12 bytes makes a nice multiple of 4.

quoted

quoted

quoted

Better safe than sorry, it's the layout of the registers in hardware,
don't let the compiler optimize here.

quoted

quoted

Actually __packed makes it less safe, as the compiler now assumes
the u32 id member is unaligned, and thus may turn 32-bit accesses into 4
byte accesses.

quoted

quoted

Fortunately it won't happen in this case as the code uses writel/readl to
acces the id member.

quoted

Yes, as this are registers they must not be accessed directly. However
we can use "__attribute__ ((packed, aligned(4)))" to tell the compiler
that the base address of this struct is always aligned to 4 bytes.

I truly think using packed here is rediculous, please remove it unless
you can prove that things won't work without it.

    They will. But how about the following 'struct rcar_can_regs'?

Thanks.

WBR, Sergei