Thread (15 messages) 15 messages, 4 authors, 2014-01-16

Re: [PATCH net-next v3 4/5] net-sysfs: add support for device-specific rx queue sysfs attributes

From: Michael Dalton <hidden>
Date: 2014-01-16 19:51:07
Also in: virtualization

On Thu, Jan 16, 2014 Ben Hutchings [off-list ref] wrote:
It's simpler but we don't know if it's faster (and I don't believe that
matters for the current usage).

If one of these functions starts to be used in the data path, at that
point it could be worth optimising, e.g. by doing a test for queue 0 and
only then doing the pointer arithmetic with its implicit division.
Good catch, my statement above is incorrect. We don't know if this change
is a performance win, and it does introduce an implicit div. I agree this
function is not currently performance critical and is used only by for
reporting values to sysfs.

Best,

Mike
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help