On Thu, 2014-01-16 at 11:07 -0800, Michael Dalton wrote:

On Jan 16, 2014 at 10:57 AM, Ben Hutchings [off-list ref] wrote:

quoted

Why write a loop when you can do:
        i = queue - dev->_rx;

Good point, the loop approach was done in get_netdev_queue_index --
I agree your fix is faster and simpler. I'll fix in next patchset.

It's simpler but we don't know if it's faster (and I don't believe that
matters for the current usage).

If one of these functions starts to be used in the data path, at that
point it could be worth optimising, e.g. by doing a test for queue 0 and
only then doing the pointer arithmetic with its implicit division.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.