Re: [PATCH net-next v3 5/5] virtio-net: initial rx sysfs support, export mergeable rx buffer size
From: Michael Dalton <hidden>
Date: 2014-01-16 16:33:38
Also in:
virtualization
From: Michael Dalton <hidden>
Date: 2014-01-16 16:33:38
Also in:
virtualization
Hi Michael, On Thu, Jan 16, 2014 at 3:53 AM, Michael S. Tsirkin [off-list ref] wrote:
Hmm this adds overhead just to prevent sysfs from getting wrong value. Can't sysfs simply disable softirq while it's reading the value?
Yes I think this would work, we could call napi_disable(), read the average packet length from the receive_queue, and then call virtnet_napi_enable(). That would eliminate the need for the seqcount. Best, Mike