Thread (20 messages) flat view 20 messages, 5 authors, 2014-01-09

Re: [net-next 3/7] ixgbe: Use static inlines instead of macros

From: David Miller <davem@davemloft.net>
Date: 2014-01-09 20:20:00

From: "Rustad, Mark D" <redacted>
Date: Thu, 9 Jan 2014 20:14:51 +0000
Obviously I could do it here, but I *really* think it is
procedurally a really bad idea to change the case as part of a
functional change. I thought I was doing a favor my at least making
them inlines, but prehaps not.
It is never a good idea to allow functions to have all caps
names and vice versa.  Please don't use "difficulty" as a reason
to violate this.

Doing things right is sometimes hard, I'm sorry to inform you :)
Anyone want to take on changing the upper case static inlines in
mcf8390, 7990, benet, ns83820, s2io, vxge, iwlwifi, ath9k, wil6210,
mwifiex, and rtlwifi? And those are just under drivers/net.
Sorry the "crap exists elsewhere, therefore I can make crap too"
argument never holds any water.

Just because crap exists elsewhere, doesn't mean you should duplicate it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help