Re: [net-next 3/7] ixgbe: Use static inlines instead of macros

From: "Rustad, Mark D" <redacted>
Date: Thu, 9 Jan 2014 17:34:18 +0000

On Jan 8, 2014, at 12:47 AM, Scott Feldman [off-list ref] wrote:

quoted

On Jan 7, 2014, at 11:40 PM, Aaron Brown [off-list ref] wrote:

quoted

From: Mark Rustad <redacted>

-#define IXGBE_WRITE_REG(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
+static inline void IXGBE_WRITE_REG(struct ixgbe_hw *hw, u32 reg, u32 value)

Bummer, now you have a all-caps func name.

Agreed, but this is actually a fairly common condition among drivers that used to use macros. It isn't perfect, but at least it is moving in the right direction. I'd rather leave the case change for a later patch series that does only that or has some reason to touch all of the register access sites.

At least the new accessor I introduced is lower case. :-)

Please address this feedback, all caps function names are really not
appropriate.