Re: [net-next 2/7] ixgbe: Indicate removal state explicitly

On Jan 8, 2014, at 12:37 AM, Scott Feldman [off-list ref] wrote:

On Jan 7, 2014, at 11:40 PM, Aaron Brown [off-list ref] wrote:

quoted

From: Mark Rustad <redacted>

Add a bit, __IXGBE_REMOVE, to indicate that the module is being
removed. The __IXGBE_DOWN bit had been overloaded for this purpose,
but that leads to trouble. A few places now check both __IXGBE_DOWN
and __IXGBE_REMOVE. Notably, setting either bit will prevent service
task execution.

Signed-off-by: Mark Rustad <redacted>
Tested-by: Phil Schmitt <redacted>
Signed-off-by: Aaron Brown <redacted>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 +
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++----
2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 49531cd..8da263a 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h

@@ -798,6 +798,7 @@ enum ixgbe_state_t {

	__IXGBE_TESTING,
	__IXGBE_RESETTING,
	__IXGBE_DOWN,
+	__IXGBE_REMOVE,

__IXGBE_REMOVING?  More consistent with _TESTING, _RESETTING, etc.

And more correct in actual meaning as well. Another good suggestion.

-- 
Mark Rustad, Networking Division, Intel Corporation