Hello.

On 09/12/2013 04:11 AM, Jingoo Han wrote:

quoted

quoted

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

quoted

quoted

Signed-off-by: Jingoo Han <redacted>
---
   drivers/net/ethernet/fealnx.c |    4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)

quoted

quoted

diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
index c706b7a..99194d1 100644
--- a/drivers/net/ethernet/fealnx.c
+++ b/drivers/net/ethernet/fealnx.c

@@ -699,9 +699,9 @@ static void fealnx_remove_one(struct pci_dev *pdev)
   		pci_iounmap(pdev, np->mem);
   		free_netdev(dev);
   		pci_release_regions(pdev);
-		pci_set_drvdata(pdev, NULL);
-	} else
+	} else {
   		printk(KERN_ERR "fealnx: remove for unknown device\n");
+	}

quoted

     No "drove-by" coding style fixes, please.

Hi Sergei,

Sorry, but I just want to know the reason. :-)
Would you let know the reason not to add coding style fixes?

    This change doesn't get covered by the patch subject/changelog. Even if 
you're doing it, it should preferably be done in a separate patch and at the 
very least documented in the changelog.

Thank you.

    Not at all.

Best regards,
Jingoo Han

WBR, Sergei