Re: [PATCH 14/52] net: cxgb4vf: remove unnecessary pci_set_drvdata()
From: Casey Leedom <hidden>
Date: 2013-09-11 17:24:21
I agree that the redundant pci_set_drvdata(pdev, NULL) in cxgb4vf_pci_probe() under the err_release_regions: label is unneeded, but don't we need to NULL out the PCI Driver Data under the err_free_adapter: label and also in cxgb4vf_pci_remove()? Or is that handled automatically in the PCI infrastructure code which calls the Device Probe and Remove routines? Mostly I was just being an obsessively clean housewife assuming that we'd want to clean up these references ... Casey On 09/11/13 00:34, Jingoo Han wrote:
quoted hunk ↗ jump to hunk
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <redacted> --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index 40c22e7..43bb012 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c@@ -2782,11 +2782,9 @@ err_unmap_bar: err_free_adapter: kfree(adapter); - pci_set_drvdata(pdev, NULL); err_release_regions: pci_release_regions(pdev); - pci_set_drvdata(pdev, NULL); pci_clear_master(pdev); err_disable_device:@@ -2851,7 +2849,6 @@ static void cxgb4vf_pci_remove(struct pci_dev *pdev) } iounmap(adapter->regs); kfree(adapter); - pci_set_drvdata(pdev, NULL); } /*