Re: [PATCH 22/52] net: e100: remove unnecessary pci_set_drvdata()
From: Jeff Kirsher <hidden>
Date: 2013-09-11 08:40:07
Attachments
- signature.asc [application/pgp-signature] 836 bytes
From: Jeff Kirsher <hidden>
Date: 2013-09-11 08:40:07
On Wed, 2013-09-11 at 16:45 +0900, Jingoo Han wrote:
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <redacted> --- drivers/net/ethernet/intel/e100.c | 2 -- 1 file changed, 2 deletions(-)
While I do not find anything wrong with this patch, I personally like good housekeeping so I would like to keep the code as is. Is there a reason for this patch?