Re: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module

On 23.08.2013 16:59, Sergei Shtylyov wrote:

On 23-08-2013 18:16, Daniel Mack wrote:

quoted

+	priv->gmii_sel_reg = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(priv->gmii_sel_reg)) {
+		dev_err(priv->dev, "unable to map control i/o region\n");

    You didn't actually seem to heed my words about error message.

Well yes I did, but only in the check for platform_get_resource(). As
the comment says - we pass on if that memory region is not given, but if
it is given, it also has to be valid.

And don't  you want to do:

	res = PTR_ERR(priv->gmii_sel_reg);

Erm, of course. Sorry for that.


Daniel