Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string

On Friday 23 August 2013 11:22 AM, Benoit Cousson wrote:

Hi Santosh,

[...]

quoted

quoted

+static const struct of_device_id cpsw_of_mtable[] = {
+    {
+        .compatible    = "ti,am3352-cpsw",

I didn't notice this earlier, but can't you use the IP version
as a compatible instead of using a SOC name. Whats really SOC specific
on this IP ? Sorry i have missed any earlier discussion on this but
this approach doesn't seem good. Its like adding SOC checks in the
driver subsystem.

Hehe, welcome to the club!
I keep arguing about that as well :-)

I think we should create a Facebook group: "against-the-soc-version-in-the-compatible-string".

Indeed !!

Regards,
Santosh