Thread (15 messages) 15 messages, 8 authors, 2013-08-01

Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link

From: Uwe Kleine-König <hidden>
Date: 2013-07-31 08:17:04

On Tue, Jul 30, 2013 at 04:05:30PM -0700, David Miller wrote:
From: Uwe Kleine-König <redacted>
Date: Tue, 30 Jul 2013 11:29:40 +0200
quoted
Don't test for having link and let hardware deal with this situation.

Without this patch I see a machine running an -rt patched Linux being
stuck in sch_direct_xmit when it looses link while there is still a
packet to be sent. In this case the fec_enet_start_xmit routine returned
NETDEV_TX_BUSY which makes the network stack reschedule the packet and
so sch_direct_xmit calls fec_enet_start_xmit again.
I failed to reproduce a complete hang without -rt, but I think the
problem exists there, too.

Signed-off-by: Uwe Kleine-König <redacted>
Applied, thanks.
Thanks, I see it as a264b981f2c76e281ef27e7232774bf6c54ec865 in net.git
(i.e.
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a264b981f2c76e281ef27e7232774bf6c54ec865)

You missed to take the

	Acked-and-tested-by: Fugang Duan [off-list ref]

. If you want to fix that, you can do:

	git filter-branch --msg-filter 'if test $GIT_COMMIT = a264b981f2c76e281ef27e7232774bf6c54ec865; then sed "/David/ i Acked-and-tested-by: Fugang Duan [off-list ref]"; else cat; fi' a264b981f2c76e281^..

on your master branch to add it to that commit.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help