Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link

[PATCH] net/fec: call netif_carrier_off when not having link · Uwe Kleine-König <hidden> · 2013-07-25
Re: [PATCH] net/fec: call netif_carrier_off when not having link · Stephen Hemminger <stephen@networkplumber.org> · 2013-07-25
RE: [PATCH] net/fec: call netif_carrier_off when not having link · Duan Fugang-B38611 <hidden> · 2013-07-26
Re: [PATCH] net/fec: call netif_carrier_off when not having link · Florian Fainelli <florian@openwrt.org> · 2013-07-26
Re: [PATCH] net/fec: call netif_carrier_off when not having link · Sascha Hauer <s.hauer@pengutronix.de> · 2013-07-26
Re: [PATCH] net/fec: call netif_carrier_off when not having link · Ben Hutchings <hidden> · 2013-07-26
RE: [PATCH] net/fec: call netif_carrier_off when not having link · Duan Fugang-B38611 <hidden> · 2013-07-29
RE: [PATCH] net/fec: call netif_carrier_off when not having link · Duan Fugang-B38611 <hidden> · 2013-07-29
[PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · Uwe Kleine-König <hidden> · 2013-07-30
RE: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · Duan Fugang-B38611 <hidden> · 2013-07-30
Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · David Miller <davem@davemloft.net> · 2013-07-30
Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · Uwe Kleine-König <hidden> · 2013-07-31
Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · David Miller <davem@davemloft.net> · 2013-07-31
RE: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · Duan Fugang-B38611 <hidden> · 2013-08-01
Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link · Steven Rostedt <rostedt@goodmis.org> · 2013-08-01

From: David Miller <davem@davemloft.net>
Date: 2013-07-30 23:05:34

From: Uwe Kleine-König <redacted>
Date: Tue, 30 Jul 2013 11:29:40 +0200

Don't test for having link and let hardware deal with this situation.

Without this patch I see a machine running an -rt patched Linux being
stuck in sch_direct_xmit when it looses link while there is still a
packet to be sent. In this case the fec_enet_start_xmit routine returned
NETDEV_TX_BUSY which makes the network stack reschedule the packet and
so sch_direct_xmit calls fec_enet_start_xmit again.
I failed to reproduce a complete hang without -rt, but I think the
problem exists there, too.

Signed-off-by: Uwe Kleine-König <redacted>

Applied, thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help