RE: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link
From: Duan Fugang-B38611 <hidden>
Date: 2013-08-01 02:01:25
On Thu, Aug 01, 2013 at 02:51 AM, David Miller wrote:
quoted
On Tue, Jul 30, 2013 at 04:05:30PM -0700, David Miller wrote:quoted
From: Uwe Kleine-König <redacted> Date: Tue, 30 Jul 2013 11:29:40 +0200quoted
Don't test for having link and let hardware deal with this situation. Without this patch I see a machine running an -rt patched Linux being stuck in sch_direct_xmit when it looses link while there is still a packet to be sent. In this case the fec_enet_start_xmit routine returned NETDEV_TX_BUSY which makes the network stack reschedule the packet and so sch_direct_xmit calls fec_enet_start_xmit again. I failed to reproduce a complete hang without -rt, but I think the problem exists there, too. Signed-off-by: Uwe Kleine-König <redacted>Applied, thanks.Thanks, I see it as a264b981f2c76e281ef27e7232774bf6c54ec865 in net.git (i.e. https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id= a264b981f2c76e281ef27e7232774bf6c54ec865) You missed to take the Acked-and-tested-by: Fugang Duan [off-list ref]This is not an official tag recognized by patchwork, he should say: Acked-by: Fugang Duan <redacted> Tested-by: Fugang Duan <redacted>
I see Linux kernel trees have many non-official tag such as: Acked-and-tested-by. Anyway, we must follow the official rules. Thanks, David.