Mon, Jul 22, 2013 at 01:46:01PM CEST, Narendra_K@Dell.com wrote:

On Sun, Jul 21, 2013 at 08:18:23PM +0530, Ben Hutchings wrote:

quoted

On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote:

quoted

On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko [off-list ref] wrote:
[...]

Sorry, I missed that fact that initially you responded on this thread

quoted

The value could be anything. But note that you have to have different
values for card1-port1,2 and card2-port1,2

why?

The intent is to identify physical ports uniquely, so userland can tell
whether two devices are backed by the same physical port.

But there's no requirement on the format, so you could ensure that one
byte of this identifier is the port number on the board.

Would it be useful to embed the port number at a known offset to ensure
uniformity across all drivers, if a driver choses to embed port number
as part of phys_port_id ? 

I would not do that. Just let it be meaningless number. That is best for
security reasons as well.

-- 
With regards,
Narendra K
Linux Engineering
Dell Inc.