Thread (23 messages) 23 messages, 6 authors, 2013-07-22

Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs

From: Or Gerlitz <hidden>
Date: 2013-07-21 20:29:34

On Sun, Jul 21, 2013 at 5:48 PM, Ben Hutchings
[off-list ref] wrote:
On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote:
quoted
On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko [off-list ref] wrote:
[...]

Sorry, I missed that fact that initially you responded on this thread
quoted
The value could be anything. But note that you have to have different
values for card1-port1,2 and card2-port1,2
why?
The intent is to identify physical ports uniquely, so userland can tell
whether two devices are backed by the same physical port.
OK this makes sense, and I understand that there are also some SRIOV
aspects / use cases where this field could be usefu, still I don't
understamd the direct relation to virtual functions, as mentioned in
the 1st patch.
But there's no requirement on the format, so you could ensure that one
byte of this identifier is the port number on the board.

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help