-----Original Message-----
From: David Laight [mailto:David.Laight@ACULAB.COM]
Sent: Thursday, June 27, 2013 1:56 AM
To: Shahed Shaikh; Jitendra Kalsaria; David Miller
Cc: netdev; Sony Chacko; Dept-NX Linux NIC Driver
Subject: RE: [PATCH net-next 4/8] qlcnic: Add support for PEX DMA method
to read memory section of adapter dump

quoted

quoted

quoted

+	if ((tmpl_hdr->version & 0xffffff) >= 0x20001)
+		ahw->fw_dump.use_pex_dma = true;
+	else
+		ahw->fw_dump.use_pex_dma = false;

You know what's wrong with the above....

Yes. Got it.  Masking is not done properly. It should be if
((tmpl_hdr->version & 0xfffff) >= 0x20001)

Try:
	ahw->fw_dump.use_pex_dma = (tmpl_hdr->version & 0xfffff) >=
0x20001;

Ok. Thanks David.

-Shahed

	David