On 6/21/13 10:10 AM, "Joe Perches" [off-list ref] wrote:

On Fri, 2013-06-21 at 12:30 -0400, Jitendra Kalsaria wrote:

quoted

From: Jitendra Kalsaria <redacted>

Add support for configuring secondary unicast address which
will use existing HW filters to store all the unicast MAC
addresses and prevent device going into promiscuous mode.

[]

quoted

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h

b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h

[]

quoted

@@ -421,6 +421,7 @@ struct qlcnic_hardware_context {
+	u8 max_uc_count;

quoted

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h

b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h

[]

quoted

+#define QLC_83XX_MAX_UC_COUNT			4096

quoted

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h

b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h

[]

quoted

+#define QLCNIC_MAX_UC_COUNT		512

These #defines don't seem right.
There's no way to fit these values in a u8.

Thanks for pointing it, I will fix it and resubmit these series again.