RE: [PATCH net-next 4/8] qlcnic: Add support for PEX DMA method to read memory section of adapter dump
From: David Laight <hidden>
Date: 2013-06-27 08:56:54
From: David Laight <hidden>
Date: 2013-06-27 08:56:54
quoted
quoted
+ if ((tmpl_hdr->version & 0xffffff) >= 0x20001) + ahw->fw_dump.use_pex_dma = true; + else + ahw->fw_dump.use_pex_dma = false;You know what's wrong with the above....Yes. Got it. Masking is not done properly. It should be if ((tmpl_hdr->version & 0xfffff) >= 0x20001)
Try: ahw->fw_dump.use_pex_dma = (tmpl_hdr->version & 0xfffff) >= 0x20001; David