Thread (24 messages) flat view 24 messages, 7 authors, 2013-02-23
STALE4933d

Re: [PATCH 1/1] net: fec: fix miss init spinlock

From: David Miller <davem@davemloft.net>
Date: 2013-02-04 05:24:10
Also in: linux-arm-kernel

From: Frank Li <redacted>
Date: Mon, 4 Feb 2013 10:22:23 +0800
2013/2/3 David Miller [off-list ref]:
quoted
From: Frank Li <redacted>
Date: Fri, 1 Feb 2013 16:56:26 +0800
quoted
@@ -1607,6 +1607,7 @@ static int fec_enet_init(struct net_device *ndev)
      }

      spin_lock_init(&fep->hw_lock);
+     spin_lock_init(&fep->tmreg_lock);
This breaks the build, tmreg_lock is only present in certain
configurations.
No, FEC have changed to check dramatically instead of static config.
You can look fec.h.  tmreg_lock is always defined.
Not in the 'net' tree or you don't want this bug fixed there at all?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help