Re: [PATCH 1/1] net: fec: fix miss init spinlock

2013/2/3 David Miller [off-list ref]:

From: Frank Li <redacted>
Date: Fri, 1 Feb 2013 16:56:26 +0800

quoted

@@ -1607,6 +1607,7 @@ static int fec_enet_init(struct net_device *ndev)
      }

      spin_lock_init(&fep->hw_lock);
+     spin_lock_init(&fep->tmreg_lock);

This breaks the build, tmreg_lock is only present in certain
configurations.

No, FEC have changed to check dramatically instead of static config.
You can look fec.h.  tmreg_lock is always defined.

        struct  napi_struct napi;

        struct ptp_clock *ptp_clock;
        struct ptp_clock_info ptp_caps;
        unsigned long last_overflow_check;
        spinlock_t tmreg_lock;
        struct cyclecounter cc;
        struct timecounter tc;
        int rx_hwtstamp_filter;
        u32 base_incval;
        u32 cycle_speed;
        int hwts_rx_en;
        int hwts_tx_en;
        struct timer_list time_keep;

best regards
Frank Li