Thread (24 messages) flat view 24 messages, 7 authors, 2013-02-23

Re: [PATCH 1/1] net: fec: fix miss init spinlock

From: Frank Li <hidden>
Date: 2013-02-07 01:42:41

2013/2/6 Waskiewicz Jr, Peter P [off-list ref]:
On 2/6/2013 1:50 AM, Frank Li wrote:
quoted

It is not easy to fix. Need put tx to NAPI poll function.
I will work on that after China New year holiday

Converting Tx to NAPI is the best solution, but you can put a temporary fix
in.  Don't take a spin_lock() in fec_enet_tx(), rather take a
spin_lock_irqsave() since you're still in HARDIRQ context.
That's not help.
skb_tx_timestamp function call some function using lock, which lock
used at the other place, just call spinlock_bh.

skb_tx_timestamp seem be called only in softirq context, not irq context.
-PJ
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help