Re: [PATCH v2 1/4] sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow()
From: Neil Horman <nhorman@tuxdriver.com>
Date: 2013-02-28 14:31:58
From: Neil Horman <nhorman@tuxdriver.com>
Date: 2013-02-28 14:31:58
On Wed, Feb 27, 2013 at 11:54:30AM -0700, Lee A. Roberts wrote:
From: "Lee A. Roberts" <redacted> Resolve SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association lobby (ordering) queue. Close examination of reassembly/ordering queues shows duplicated packets. In sctp_tsnmap_mark(), correct off-by-one error when calculating size value for sctp_tsnmap_grow(). In sctp_tsnmap_grow(), correct off-by-one error when copying and resizing the tsnmap. If max_tsn_seen is in the LSB of the word, this bit can be lost, causing the corresponding packet to be transmitted again and to be entered as a duplicate into the SCTP reassembly/ordering queues. Change parameter name from "gap" (zero-based index) to "size" (one-based) to enhance code readability. Signed-off-by: Lee A. Roberts <redacted>
Acked-by: Neil Horman <nhorman@tuxdriver.com>