Re: [PATCH v2 0/4] sctp: fix association hangs due to reassembly/ordering logic
From: Daniel Borkmann <hidden>
Date: 2013-02-27 19:36:55
Also in:
linux-sctp
From: Daniel Borkmann <hidden>
Date: 2013-02-27 19:36:55
Also in:
linux-sctp
On 02/27/2013 07:54 PM, Lee A. Roberts wrote:
From: "Lee A. Roberts" <redacted> This series of patches resolves several SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association reassembly and/or lobby (ordering) queues. Close examination of reassembly/ordering queues may show either duplicated or missing packets.
Just nitpicking here ... all of your 4 patches have the same first paragraph, which can actually be left out completely if it is already in your patch cover letter stated.
Lee A. Roberts (4):
sctp: fix association hangs due to off-by-one errors in
sctp_tsnmap_grow()
sctp: fix association hangs due to reneging packets below the
cumulative TSN ACK point
sctp: fix association hangs due to errors when reneging events from
the ordering queue
sctp: fix association hangs due to partial delivery errors
net/sctp/tsnmap.c | 13 ++++----
net/sctp/ulpqueue.c | 87 +++++++++++++++++++++++++++++++++++++++++----------
2 files changed, 78 insertions(+), 22 deletions(-)