Re: [PATCH 0/4] sctp: fix association hangs due to reassembly/ordering logic
From: David Miller <davem@davemloft.net>
Date: 2013-02-27 18:10:00
From: "Lee A. Roberts" <redacted> Date: Tue, 26 Feb 2013 07:36:12 -0700
From: "Lee A. Roberts" <redacted>
This series of patches resolves several SCTP association hangs observed during
SCTP stress testing. Observable symptoms include communications hangs with
data being held in the association reassembly and/or lobby (ordering) queues.
Close examination of reassembly/ordering queues may show either duplicated
or missing packets.
Lee A. Roberts (4):
sctp: fix association hangs due to off-by-one errors in
sctp_tsnmap_grow()
sctp: fix association hangs due to reneging packets below the
cumulative TSN ACK point
sctp: fix association hangs due to errors when reneging events from
the ordering queue
sctp: fix association hangs due to partial delivery errorsAppying these patches breaks the build: net/sctp/ulpqueue.c: In function ‘sctp_ulpq_renege’: net/sctp/ulpqueue.c:1115:4: warning: passing argument 2 of ‘sctp_ulpq_partial_delivery’ makes integer from pointer without a cast [enabled by default] net/sctp/ulpqueue.c:1038:6: note: expected ‘gfp_t’ but argument is of type ‘struct sctp_chunk *’ net/sctp/ulpqueue.c:1115:4: error: too many arguments to function ‘sctp_ulpq_partial_delivery’ net/sctp/ulpqueue.c:1038:6: note: declared here