Re: [PATCH 5/5] smsc95xx: expand check_ macros

On 3 December 2012 10:41, David Laight [off-list ref] wrote:

quoted

-             check_warn_return(ret, "Error reading MII_ACCESS\n");
+             if (ret < 0) {
+                     netdev_warn(dev->net, "Error reading MII_ACCESS\n");
+                     return ret;
+             }
+

It might be worth defining something like:

#define check_warn(dev, ret, errmsg) \
        (ret >= 0 ? 0 : (netdev_warn(dev->net, errmsg), ret))

so the above code can be:
        if (check_warn(dev, ret, "Error reading MII_ACCESS\n"))
                return ret;

Thanks David, I'd rather not define this kind of macro locally though.
 I'm happy to use something like this but only if it's something
that's centrally defined, blessed by davem, and if it's something that
all drivers are intended to use.  Otherwise we end up with subtly
different macros in different drivers, and subtly different behaviours
in each.

Steve