Re: [PATCH 1/5] smsc95xx: fix suspend buffer overflow
From: Joe Perches <joe@perches.com>
Date: 2012-11-30 16:03:41
On Fri, 2012-11-30 at 15:55 +0000, Steve Glendinning wrote:
This patch fixes a buffer overflow introduced by bbd9f9e, where the filter_mask array is accessed beyond its bounds.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
[]
quoted hunk ↗ jump to hunk
@@ -1281,7 +1281,7 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message) } if (pdata->wolopts & (WAKE_BCAST | WAKE_MCAST | WAKE_ARP | WAKE_UCAST)) { - u32 *filter_mask = kzalloc(32, GFP_KERNEL); + u32 *filter_mask = kzalloc(sizeof(u32) * 32, GFP_KERNEL);
Just get rid of the alloc and use 32 u8's on stack. It's small enough No filter value is > FF and the compiler with expand the u8 to u32 when writing to the card.