- check_warn_return(ret, "Error reading MII_ACCESS\n");
+ if (ret < 0) {
+ netdev_warn(dev->net, "Error reading MII_ACCESS\n");
+ return ret;
+ }
+
It might be worth defining something like:
#define check_warn(dev, ret, errmsg) \
(ret >= 0 ? 0 : (netdev_warn(dev->net, errmsg), ret))
so the above code can be:
if (check_warn(dev, ret, "Error reading MII_ACCESS\n"))
return ret;
David