Thread (21 messages) 21 messages, 3 authors, 2012-11-21

Re: [PATCH v2] checkpatch: add double empty line check

flat view

From: Andy Whitcroft <apw@canonical.com>
Date: 2012-11-20 19:32:55
Also in: lkml

On Tue, Nov 20, 2012 at 09:10:35PM +0200, Eilon Greenstein wrote:
About the logic - true, if diff will show deleted lines after newly
added lines, some new double line segments will be missed. However, it
seems like few other things will break if diff will start acting out
like that. The suggestion you posted earlier will miss those as well,
and starting to check for this weird case (of deleted lines after the
added lines) does not seem right.
Actually the version I sent should indeed cope with the deleted lines
regardless of order.  It was cirtainly intended to.

-apw
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help