RE: [PATCH 3/5] net: davinci_mdio: Fix type mistake in calling runtime-pm api
flat view
STALE5109d
From: Hiremath, Vaibhav <hidden>
Date: 2012-10-18 16:13:43
Also in:
linux-arm-kernel
On Tue, Oct 16, 2012 at 00:46:33, Richard Cochran wrote:
From: Vaibhav Hiremath <redacted> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() api, driver is calling pm_runtime_put_sync() api in resume callback function. The bug was introduced by commit id (ae2c07aaf74: davinci_mdio: runtime PM support). Now, the reason why it didn't impact functionality is, the patch has been tested on AM335x-EVM and BeagleBone platform while submitting; and in case of AM335x the MDIO driver doesn't control the module enable/disable part, which is handled by CPSW driver. Signed-off-by: Vaibhav Hiremath <redacted> Cc: Mugunthan V N <redacted>
Thanks for submitting the patches, I couldn't able to do it for almost 2 weeks now. I really appreciate it. Thanks, Vaibhav
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/ti/davinci_mdio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index 51a96db..ae74280 100644 --- a/drivers/net/ethernet/ti/davinci_mdio.c +++ b/drivers/net/ethernet/ti/davinci_mdio.c@@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev) u32 ctrl; spin_lock(&data->lock); - pm_runtime_put_sync(data->dev); + pm_runtime_get_sync(data->dev); /* restart the scan state machine */ ctrl = __raw_readl(&data->regs->control);-- 1.7.2.5