Re: [PATCH 1/5] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode

* Jon Hunter [off-list ref] [121017 07:43]:

On 10/16/2012 04:26 PM, Tony Lindgren wrote:

quoted

* Jon Hunter [off-list ref] [121016 14:00]:

quoted

Hi Tony,

On 10/16/2012 12:48 PM, Tony Lindgren wrote:

quoted

* Richard Cochran [off-list ref] [121015 12:18]:

quoted

From: hvaibhav@ti.com <redacted>

With recent changes in omap gpmc driver code, in case of DT
boot mode, where bootloader does not configure gpmc cs space
will result into kernel BUG() inside gpmc_mem_init() function,
as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and
gpmc_config7[0].baseaddress is set to '0' on reset.

This use-case is applicable for any board/EVM which doesn't have
any peripheral connected to gpmc cs0, for example BeagleXM and
BeagleBone, so DT boot mode fails.

This patch adds of_have_populated_dt() check before creating
device, so that for DT boot mode, gpmc probe will not be called
which is expected behavior, as gpmc is not supported yet from DT.

I'm applying this one into omap-for-v3.7-rc1/fixes-part2.

Next time, please also cc linux-omap@vger.kernel.org for series
like this. I'm sure the people reading the omap list are interested
in these.

This patch appears to be masking an underlying issue. How about 
something like the following ...

OK that looks good to me. I'll drop the earlier fix and use
yours instead.

Hi Tony, sorry but I realised now that in my patch that I need to
take care of releasing and memory and clocks that were acquired 
during the probe. Here is a V2. If you prefer I can create a delta
patch also with the previous. 

OK thanks I'll update it.

Regards,

Tony