Re: alignment faults in 3.6

Jon Masters [off-list ref] writes:

Hi everyone,

On 10/05/2012 10:33 AM, Rob Herring wrote:

quoted

On 10/05/2012 09:05 AM, Russell King - ARM Linux wrote:

quoted

On Fri, Oct 05, 2012 at 07:24:44AM -0500, Rob Herring wrote:

quoted

On 10/05/2012 03:24 AM, Russell King - ARM Linux wrote:

quoted

Does it matter?  I'm just relaying the argument against adding __packed
which was used before we were forced (by the networking folk) to implement
the alignment fault handler.

It doesn't really matter what will be accepted or not as adding __packed
to struct iphdr doesn't fix the problem anyway. gcc still emits a ldm.
The only way I've found to eliminate the alignment fault is adding a
barrier between the 2 loads. That seems like a compiler issue to me if
there is not a better fix.

This turns out to be caused by pointers being typecast to normal
(aligned) types.

quoted

quoted

Even so, please test the patch I've sent you in the sub-thread - that
needs testing whether or not GCC is at fault.  Will's patch to add the
warnings _has_ uncovered a potential issue with the use of __get_user()
in some parts of the ARM specific kernel, and I really need you to test
that while you're experiencing this problem.

I've tested your patch and it appears to fix things. Thanks!

[...]

quoted

Now on to getting rid of faults on practically every single received IP
packet:

Multi:          9871002

RX packets:9872010 errors:0 dropped:0 overruns:0 frame:0

This will still be a problem, indeed. At least we can be aware we're
taking a large number of faults and hope for a netdev solution.

There are exactly two possible solutions:

1. Change the networking code so those structs are always aligned.  This
   might not be (easily) possible.
2. Mark the structs __packed and fix any typecasts like the ones seen in
   this thread.  This will have an adverse effect in cases where the
   structs are in fact aligned.

Both solutions lie squarely in the networking code.  It's time to
involve that list, or we'll never get anywhere.

-- 
Måns Rullgård
mans@mansr.com