[PATCH net-next v5 0/8] net: bcmgenet: support larger MTUs
flat view
HOTtoday
From: Nicolai Buchwitz <nb@tipi-net.de>
Date: 2026-10-13 14:20:43
Also in:
lkml
Revision v5 of 5 in this series.
Revisions (5)
Larger MTU aka. jumbo frames are requested often by Raspberry Pi users, but the hardware has its quirks with larger frames, so it never got done. Dave Stevenson's PoC [1] had the receive side working and Justin checked the RTL what the hardware does with long frames, which got me past the rest. GENET never sets dev->max_mtu, and the packet ready thresholds cut frames off at their 2048 byte reset default. With this the receive dropped them as fragmented and transmit never sent them out. See commit messages of the patches for more details. Patch 1 fixes a transmit error exit that left queued frames unpublished, the padding in patch 6 adds three more of them. Patches 2 to 5 and 7 implement the MTU as far as one descriptor reaches (3564 bytes with 4K pages). Patch 6 pads around a transmit quirk where a frame ending just past the threshold stops the transmitter [3]. Patch 8 reassembles the fragments the hardware produces above it, which gets the ceiling to 16347 [2]. Tested on a CM4 (GENET v5). MTU 1500 is unchanged, MTU 9000 reaches 991/987 Mbit/s. Pierre-Marin Leclercq tested on a Pi 4 (also GENET v5) with various MTU sizes. [1] https://github.com/raspberrypi/linux/pull/7614 [2] https://github.com/raspberrypi/linux/pull/7617#issuecomment-5669564355 [3] https://github.com/raspberrypi/linux/pull/7617#issuecomment-5735557324 Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de> --- Changes in v5: - collected Florian's Reviewed-by tags from v4, except on patches 6 and 7 which changed - patch 6: - move tx_thld_len to the transmit variables (clashiko) - patch 7: - take the no-op path when a failed resume already took the datapath down, the restart would otherwise free the rings twice (sashiko) - hold the PHY lock across the rebuild, a link event could otherwise take the MAC out of reset and enable it (clashiko) - reprogram the Rx mode after reattaching, a filter update that arrived while the device was detached was dropped (clashiko) To: Doug Berger <opendmb@gmail.com> To: Florian Fainelli <florian.fainelli@broadcom.com> To: Nicolai Buchwitz <nb@tipi-net.de> To: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> To: Andrew Lunn <andrew+netdev@lunn.ch> To: "David S. Miller" <davem@davemloft.net> To: Eric Dumazet <edumazet@kernel.org> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org v4: https://patch.msgid.link/20261012-nb-genet-mtu-nn-v2-v4-0-2e2e3bfaf8cc@tipi-net.de (local) v3: https://patch.msgid.link/20261007-nb-genet-mtu-nn-v2-v3-0-74a796c019ce@tipi-net.de (local) v2: https://patch.msgid.link/20261006-nb-genet-mtu-nn-v2-v2-0-c4be21151912@tipi-net.de (local) v1: https://patch.msgid.link/20261002-nb-genet-mtu-nn-v2-v1-0-96dc6d54cbee@tipi-net.de (local) --- Nicolai Buchwitz (8): net: bcmgenet: ring the doorbell when the last frame of a batch is dropped net: bcmgenet: let the caller decide whether to start the PHY net: bcmgenet: allow a continuation descriptor without the alignment pad net: bcmgenet: rename ENET_MAX_MTU_SIZE to ENET_MAX_FRAME_LEN net: bcmgenet: derive the receive buffer length from the MTU net: bcmgenet: pad transmit frames out of the packet ready window net: bcmgenet: allow the MTU to be changed net: bcmgenet: reassemble jumbo frames from status block fragments drivers/net/ethernet/broadcom/genet/bcmgenet.c | 420 ++++++++++++++++++++++--- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 25 +- 2 files changed, 396 insertions(+), 49 deletions(-) --- base-commit: d8674294aefef02266c4d47ad10131f1bffbe534 change-id: 20261002-nb-genet-mtu-nn-v2-402b5e6f306f Best regards, -- Nicolai Buchwitz [off-list ref]