RE: [PATCH v3 06/10] net/macb: clean up ring buffer logic
flat view
From: David Laight <hidden>
Date: 2012-10-30 11:21:58
Also in:
linux-arm-kernel, lkml
Instead of masking head and tail every time we increment them, just let them wrap through UINT_MAX and mask them when subscripting. Add simple accessor functions to do the subscripting properly to minimize the chances of messing this up.
...
quoted hunk ↗ jump to hunk
+static unsigned int macb_tx_ring_avail(struct macb *bp) +{ + return TX_RING_SIZE - (bp->tx_head - bp->tx_tail); +}
That one doesn't look quite right to me. Surely it should be masking with 'TX_RING_SIZE - 1' David