Thread (22 messages) 22 messages, 6 authors, 2012-09-17

Re: [net-next 1/6] igb: Tidy up wrapping for CONFIG_IGB_PTP.

flat view

From: Jeff Kirsher <hidden>
Date: 2012-09-06 09:04:22

On Thu, 2012-09-06 at 10:49 +0200, Richard Cochran wrote:
On Thu, Sep 06, 2012 at 01:44:27AM -0700, Jeff Kirsher wrote:
quoted
As I recall, he stated he was going to integrate your suggestions in a
new patch set that would follow this one.
Okay, but won't that mean moving the time stamping functions back, and
removing the #ifdefs again?
That maybe, I do not know what Matthew has in mind to integrate your
suggestions.
quoted
Also, IMHO, while I look at pre-processor tags all day and get used to
matching up #ifdef to #endif's, I still see #endif /* CONFIG_IGB_PTP */
useful.  While it is not currently consistent, I see it more useful to
fix as we go, rather than create a single patch to add a comment for
every #endif.
Okay, fine.

Thanks,
Richard
  

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help