Re: [net-next 1/6] igb: Tidy up wrapping for CONFIG_IGB_PTP.

On Thu, 2012-09-06 at 10:09 +0200, Richard Cochran wrote:

On Wed, Sep 05, 2012 at 04:35:01PM -0700, Jeff Kirsher wrote:

quoted

From: Matthew Vick <redacted>

For users without CONFIG_IGB_PTP=y, we should not be compiling any

PTP

quoted

code into the driver. Tidy up the wrapping in igb to support this.

So, you have ignored everything I wrote about time stamping
applications.

(no)Thanks,
Richard 

As I recall, he stated he was going to integrate your suggestions in a
new patch set that would follow this one.

In regards to your previous comments about the earlier patch I submitted
to wrap the code.  It was to fix a bug when the driver and time stamping
support are both modules.

Also, IMHO, while I look at pre-processor tags all day and get used to
matching up #ifdef to #endif's, I still see #endif /* CONFIG_IGB_PTP */
useful.  While it is not currently consistent, I see it more useful to
fix as we go, rather than create a single patch to add a comment for
every #endif.