Re: [PATCH] net: add new QCA alx ethernet driver

On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote:

On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:

quoted

Yes, I sent signed-off patches to their original RFC submission
(back last year?).  To me, this single large patch is like a
snapshot of a git tree and not all contributors to that git
tree should be noted as signers of the entire thing.

Ouch, that looks like we are losing all history.

One large patch should not be submitted. If it was developed in steps,
then it is best to show those steps when they are incorporated into the
Linux repository.

Sure, the patches may be reworked and folded together where appropriate,
but when I read "this single large patch is like a snapshot of a git
tree", that right there is a red flag.

I don't think this has ever been a requirement for new drivers.

The alterations to the description of atl1c ought to be broken out as a
separate patch, though.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.