Re: [PATCH] net: add new QCA alx ethernet driver
From: Joe Perches <joe@perches.com>
Date: 2012-08-09 15:22:42
Also in:
lkml
On Thu, 2012-08-09 at 10:54 -0400, Steven Rostedt wrote:
On Thu, Aug 09, 2012 at 06:49:25AM +0000, Ren, Cloud wrote:quoted
Luis has ever asked joe for adding as a Signed-off-by.
[]
I'm curious, did Luis ask on list or off?
Off vger lists with some qca list or exploder added.
The Signed-off tag has some legal bindings (all other tags are for credit/info only). It is that person saying that the changes they made to a patch are theirs and are giving the right to distribute it.
I believe I posted all patches I signed-off to vger lists.
The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. Joe, If you actually modified part of the code in the patch, you do have the right to add a signed-off-by tag. If you just made suggestions or reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more appropriate.
Yes, I sent signed-off patches to their original RFC submission (back last year?). To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing.