RE: [PATCH] net: add new QCA alx ethernet driver

Hi Jeo
I only want to do some additional explanations to david. It makes nothing with original patch.
Thanks
cloud

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com] 
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez, Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver

On Thu, 2012-08-09 at 02:27 +0000, Ren, Cloud wrote:

Hi David,

[]

The alx driver only supports two new nics(l1f/l2f) now.  It doesn't supersede atl1c driver.
Atl1c driver still supports old nics.

[]

-----Original Message-----
From: Ren, Cloud
Sent: 2012年8月9日 18:15

[]

This driver support two new ethernet chipsets:

[+400kb of entire original patch]

Did you really have to quote 400kb of original patch to make that prefixing statement to David?

[]

Signed-off-by: Joe Perches <joe@perches.com>

 
I would prefer my name not be listed as a Signed-off-by.

I don't have a card, I never tested it, etc.  What I did do is a light review and made a couple of trivial patch suggestions about how you might make logging code a bit smaller.

Thanks and cheers, Joe