Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: 2012-06-13 13:31:15
Also in:
kvm, linux-arch, lkml
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: 2012-06-13 13:31:15
Also in:
kvm, linux-arch, lkml
2012/6/13 Takuya Yoshikawa [off-list ref]:
On Wed, 13 Jun 2012 18:43:40 +0900 Akinobu Mita [off-list ref] wrote:quoted
Should this hash_table be converted from u16 hash_table[32] to DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned on long-word boundary?I think hash_table is already long-word aligned because it is placed right after a pointer.
I recommend converting to proper bitmap. Because such an implicit assumption is easily broken by someone touching this function.