Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: 2012-06-13 09:43:45
Also in:
kvm, linux-arch, lkml
2012/6/13 Takuya Yoshikawa [off-list ref]:
quoted hunk ↗ jump to hunk
From: Takuya Yoshikawa <redacted> To introduce generic set_bit_le() later, we remove our own definition and use a proper non-atomic bitops function: __set_bit_le(). Signed-off-by: Takuya Yoshikawa <redacted> Acked-by: Grant Grundler <redacted> --- drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++----- drivers/net/ethernet/dec/tulip/tulip_core.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-)diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c index 61cc093..77335853 100644 --- a/drivers/net/ethernet/dec/tulip/de2104x.c +++ b/drivers/net/ethernet/dec/tulip/de2104x.c@@ -661,9 +661,6 @@ static netdev_tx_t de_start_xmit (struct sk_buff *skb,new frame, not around filling de->setup_frame. This is non-deterministic when re-entered but still correct. */ -#undef set_bit_le -#define set_bit_le(i,p) do { ((char *)(p))[(i)/8] |= (1<<((i)%8)); } while(0) - static void build_setup_frame_hash(u16 *setup_frm, struct net_device *dev) { struct de_private *de = netdev_priv(dev);@@ -673,12 +670,12 @@ static void build_setup_frame_hash(u16 *setup_frm, struct net_device *dev)u16 *eaddrs; memset(hash_table, 0, sizeof(hash_table)); - set_bit_le(255, hash_table); /* Broadcast entry */ + __set_bit_le(255, hash_table); /* Broadcast entry */
Should this hash_table be converted from u16 hash_table[32] to DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned on long-word boundary?