Re: [PATCH] netdev: mv643xx_eth: Prevent build on PPC32

On Fri, Jun 08, 2012 at 12:51:15AM +0100, Mark Brown wrote:

On Tue, Jun 05, 2012 at 10:38:42PM -0400, Josh Boyer wrote:

quoted

1) revert the change for ARM that introduced th clk stuff
2) do a similar change as the original commit but with a bunch of
#ifdef-ery
3) implement the clkdev API stuff for 32-bit ppc

quoted

Honestly, I'd go for either 1 or 2.  The commit that introduced it was
broken to begin with, but that isn't my call.

There's a change going in which stubs out the clock API when not used
which should resolve the immediate issue, though really the best thing
here is just to enable use of the generic clock API if the platform
doesn't have one of its own - it's not just platforms that need clocks
so we really want to get that rolled out as widely as possible.

Sounds great.  I have no objections with any of those plans.

This sort of issue is just the tip of the iceberg in terms of what it's
useful to do with the API.

Yes, sounds like it.  All I ask is that people test their patches along
the way so things don't get broken.  I mean, it's great we have an
iceberg but I don't want tons of drivers on other architectures running
into the thing and sinking because people aren't being careful.  Except
maybe the one already appropriately (nick)named.

josh