Re: [PATCH] netdev: mv643xx_eth: Prevent build on PPC32

On Tue, 2012-06-05 at 15:28 -0400, Josh Boyer wrote:

Commit 452503ebc (ARM: Orion: Eth: Add clk/clkdev support.) added use of
the clk driver API which results in compile errors on architectures that
don't implement the clk API.

ERROR: "clk_enable" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "clk_disable" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "clk_put" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "clk_get_rate" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "clk_get" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!

Selecting CLKDEV_LOOKUP doesn't fix this either, as the build then fails with:

In file included from drivers/clk/clkdev.c:21:0:
include/linux/clkdev.h:15:24: fatal error: asm/clkdev.h: No such file or directory

So we just prevent this from building at all on PPC32.

[...]

This dependency was introduced by:

commit 16b817579fb61050f1abcc0e81089974328a9c27
Author: Benjamin Herrenschmidt [off-list ref]
Date:   Sat Apr 16 15:24:30 2005 -0700

    [PATCH] ppc32: MV643XX ethernet is an option for Pegasos

commit 06ede91017d015a03cf8c1c87b3ff668f9a846e0
Author: Dale Farnsworth [off-list ref]
Date:   Wed Sep 20 12:24:34 2006 -0700

    [PATCH] mv643xx_eth: restrict to 32-bit PPC_MULTIPLATFORM

If Pegasos is still supposed to be supported then this needs to be fixed
properly.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.