Re: [PATCH] netdev: mv643xx_eth: Prevent build on PPC32

On Wed, Jun 06, 2012 at 07:29:10AM +0200, Andrew Lunn wrote:

quoted

The proper fix, from my minimal looking, was one of:

1) revert the change for ARM that introduced th clk stuff
2) do a similar change as the original commit but with a bunch of
#ifdef-ery
3) implement the clkdev API stuff for 32-bit ppc

Honestly, I'd go for either 1 or 2.  The commit that introduced it was
broken to begin with, but that isn't my call.

I broke it. Sorry.

At the time, there was a push to remove all the #ifdefs. The following
patchset was doing this:

https://lkml.org/lkml/2012/4/21/94

it would provide dummy implementations for those systems without clk
support. However, it seems that patch set never made it in, and i did
not declare my dependency on it.

I'm happy to add #ifdef. However, i would first like to understand
what was 'broken to begin with'.

Simply that a commit was introduced that did not build on all the
existing platforms the driver supports.  The world is not ARM, or x86,
or PPC32, etc.  I haven't looked to see if it would still function
correctly in the presence of a dummy clk implementation, but if not that
would also be bad.

josh