Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms

On Tuesday 15 May 2012, Joe Perches wrote:

On Wed, 2012-05-16 at 00:37 +0200, Francois Romieu wrote:

quoted

Jaccon Bastiaansen [off-list ref] :
[...]

quoted

diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
index b9406cb..8081ad5 100644
--- a/drivers/net/ethernet/cirrus/cs89x0.c
+++ b/drivers/net/ethernet/cirrus/cs89x0.c

[...]

quoted

-static int cs89x0_probe1(struct net_device *dev, unsigned long ioaddr, int modular);
+static int cs89x0_probe1(struct net_device *dev,
+                    void __iomem *ioaddr,
+                    int modular);
+static int cs89x0_probe1(struct net_device *dev, void __iomem *ioaddr,
+                    int modular);

s/int/bool/ maybe.

You may skip the name of the parameters.

Better would be to not duplicate the prototype
and better still would be to reorder the code to
avoid the prototype altogether.

I agree that would be best, but let's do one thing at a time. This prototype
is the first of 16 in a row in that driver. It would be good to remove all
of them, but that change is totally unrelated to the much more important
one that Jaccon is doing here.

I'd say leave the prototype as it is for now, just change the type of the ioaddr
argument in this patch. Patches to fix the numerous other style issues with this
driver are of course welcome as well.

	Arnd