Thread (5 messages) flat view 5 messages, 4 authors, 2012-05-16
STALE5204d REVIEWED: 5 (5M)

1 review trailer.

Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms

From: Arnd Bergmann <arnd@arndb.de>
Date: 2012-05-15 21:22:15
Also in: linux-arm-kernel

On Tuesday 15 May 2012, Jaccon Bastiaansen wrote:
The use of the inw/outw functions by the cs89x0 platform driver
results in NULL pointer references on ARM platforms and
platforms that do not provide ISA-style programmed I/O accessors.

Using inw/outw also accesses the wrong address space on platforms
that have a PCI I/O space that is not identity-mapped into the
physical address space.

Signed-off-by: Jaccon Bastiaansen <redacted>
Looks good to me now.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Of course we would need some testing on another platform and ideally
also on an ISA based machine, although that might be hard to
come by these days...

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help